Fix for lambda not evaluating some environment variables #42
Conversation
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
| event['subject'] = DEFAULT_EMAIL_SUBJECT; | ||
| if (event.note === undefined) | ||
| if (event.note === undefined && process.env[ENV_VAR.EMAIL_NOTE] === undefined) |
There was a problem hiding this comment.
this works but seems backwards, it's easy to miss since the code is checking process.env[ENV_VAR.EMAIL_NOTE] in both getOptions and getEventArguments. e.g. if a config file is introduced later, this needs to also check && config_file.email_note === undefined
i think peter brought this up before, it might be better to have a default options object in getOptions. If there are any explicitly defined configs, overwrite the value with the highest priority config (command arguments > environment variables), or overwrite multiple times starting from lowest priority
There was a problem hiding this comment.
Agreed. will need check how to set default options object though because currently for cli options object is created with commander program, even setting env var is happening at that time for cli https://github.com/opensearch-project/reporting-cli/blob/main/src/arguments.js#L24 and want to keep main logic same for cli/lambda/package. getOptions is setting environment variable only for lambda & credentials as it has :. Anyway will add this also to refactor issue and try to prioritize.
Description
Issues Resolved
#38
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.